shen/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2024-11-25 16:33:34 +08:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

uninstall: don't ignore deps even for developers

Browse Source 
This was discussed a while back on Slack. The idea behind this is that
ignoring dependencies during `brew uninstall` makes it too easy to break
things, even for developers. Those who know what they are doing can, and
IMO should, always use the `--ignore-dependencies` flag.
This commit is contained in:
Ruoyu Zhong 2024-04-08 23:30:05 +08:00
parent cc0b5d6d05
commit f2cb33011a
No known key found for this signature in database
2 changed files with 12 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Library/Homebrew/test/uninstall_spec.rb
View File

@ -47,17 +47,7 @@ RSpec.describe Homebrew::Uninstall do
end
describe "::handle_unsatisfied_dependents" do
specify "when developer" do
ENV["HOMEBREW_DEVELOPER"] = "1"
expect do
described_class.handle_unsatisfied_dependents(kegs_by_rack)
end.to output(/Warning/).to_stderr
expect(Homebrew).not_to have_failed
end
specify "when not developer" do
specify "when `ignore_dependencies` is false" do
expect do
described_class.handle_unsatisfied_dependents(kegs_by_rack)
end.to output(/Error/).to_stderr
@ -65,7 +55,7 @@ RSpec.describe Homebrew::Uninstall do
expect(Homebrew).to have_failed
end
specify "when not developer and `ignore_dependencies` is true" do
specify "when `ignore_dependencies` is true" do
expect do
described_class.handle_unsatisfied_dependents(kegs_by_rack, ignore_dependencies: true)
end.not_to output.to_stderr

37
Library/Homebrew/uninstall.rb
View File

@ -106,12 +106,7 @@ module Homebrew
def self.check_for_dependents(kegs, casks: [], named_args: [])
return false unless (result = InstalledDependents.find_some_installed_dependents(kegs, casks:))
if Homebrew::EnvConfig.developer?
DeveloperDependentsMessage.new(*result, named_args:).output
else
NondeveloperDependentsMessage.new(*result, named_args:).output
end
DependentsMessage.new(*result, named_args:).output
true
end
@ -124,6 +119,15 @@ module Homebrew
@named_args = named_args
end
def output
ofail <<~EOS
Refusing to uninstall #{reqs.to_sentence}
because #{(reqs.count == 1) ? "it" : "they"} #{are_required_by_deps}.
You can override this and force removal with:
#{sample_command}
EOS
end
protected
def sample_command
@ -136,27 +140,6 @@ module Homebrew
end
end
class DeveloperDependentsMessage < DependentsMessage
def output
opoo <<~EOS
#{reqs.to_sentence} #{are_required_by_deps}.
You can silence this warning with:
#{sample_command}
EOS
end
end
class NondeveloperDependentsMessage < DependentsMessage
def output
ofail <<~EOS
Refusing to uninstall #{reqs.to_sentence}
because #{(reqs.count == 1) ? "it" : "they"} #{are_required_by_deps}.
You can override this and force removal with:
#{sample_command}
EOS
end
end
def self.rm_pin(rack)
Formulary.from_rack(rack).unpin
rescue