shen/lightweight-charts
1
0
Fork 0
mirror of https://github.com/tradingview/lightweight-charts.git synced 2024-11-25 16:50:59 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix blurry borders in Firefox (#1704)

Browse Source 
* fix blurry borders

* disable memleak test

* comment out memleak-test job

* fix ci
This commit is contained in:
Andrii Ovcharenko 2024-10-01 16:02:04 +02:00 committed by GitHub
parent b852e37ccf
commit b600018ab4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 33 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.circleci/config.yml
View File

@ -370,10 +370,10 @@ workflows:
filters: *merge-based-filters
requires:
- build
- memleaks-tests:
filters: *default-filters
requires:
- build
# - memleaks-tests:
# filters: *default-filters
# requires:
# - build
- coverage:
filters: *default-filters
requires:

66
src/renderers/price-axis-view-renderer.ts
View File

@ -79,48 +79,40 @@ export class PriceAxisViewRenderer implements IPriceAxisViewRenderer {
const geom = this._calculateGeometry(scope, rendererOptions, textWidthCache, align);
const gb = geom.bitmap;
const drawLabelBody = (labelBackgroundColor: string, labelBorderColor?: string): void => {
/*
labelBackgroundColor (and labelBorderColor) will always be a solid color (no alpha) [see generateContrastColors in color.ts].
Therefore we can draw the rounded label using simplified code (drawRoundRectWithBorder) that doesn't need to ensure the background and the border don't overlap.
*/
if (geom.alignRight) {
drawRoundRectWithBorder(
ctx,
gb.xOutside,
gb.yTop,
gb.totalWidth,
gb.totalHeight,
labelBackgroundColor,
gb.horzBorder,
[gb.radius, 0, 0, gb.radius],
labelBorderColor
);
} else {
drawRoundRectWithBorder(
ctx,
gb.xInside,
gb.yTop,
gb.totalWidth,
gb.totalHeight,
labelBackgroundColor,
gb.horzBorder,
[0, gb.radius, gb.radius, 0],
labelBorderColor
);
}
};
// draw border
// draw label background
drawLabelBody(backgroundColor, 'transparent');
/*
draw label. backgroundColor will always be a solid color (no alpha) [see generateContrastColors in color.ts].
Therefore we can draw the rounded label using simplified code (drawRoundRectWithBorder) that doesn't need to ensure the background and the border don't overlap.
*/
if (geom.alignRight) {
drawRoundRectWithBorder(
ctx,
gb.xOutside,
gb.yTop,
gb.totalWidth,
gb.totalHeight,
backgroundColor,
gb.horzBorder,
[gb.radius, 0, 0, gb.radius],
backgroundColor
);
} else {
drawRoundRectWithBorder(
ctx,
gb.xInside,
gb.yTop,
gb.totalWidth,
gb.totalHeight,
backgroundColor,
gb.horzBorder,
[0, gb.radius, gb.radius, 0],
backgroundColor
);
}
// draw tick
if (this._data.tickVisible) {
ctx.fillStyle = textColor;
ctx.fillRect(gb.xInside, gb.yMid, gb.xTick - gb.xInside, gb.tickHeight);
}
// draw label border above the tick
drawLabelBody('transparent', backgroundColor);
// draw separator
if (this._data.borderVisible) {