Commit Graph

25 Commits

Author SHA1 Message Date
renovate[bot]
004f0922e4
chore(deps): update actions/upload-artifact action to v4 2024-11-06 15:30:33 +00:00
Christopher Willis-Ford
c1da45dc34 ci: store unit and integration test results together 2024-08-28 07:24:49 -07:00
Christopher Willis-Ford
7bb299b5f8 ci: only try GH Pages deploy on primary branch(es) 2024-08-27 09:26:12 -07:00
Christopher Willis-Ford
dea503ff84 ci: run CI/CD checks on PRs from other forks 2024-08-27 07:15:54 -07:00
Christopher Willis-Ford
650464c778 ci: ensure tests use build output and simplify CI/CD workflow
Thanks, @takaokouji, for making me take a closer look at the caching
behavior in this workflow. Subtle and dangerous!

In the previous version, the `build/` directory was cached with this
key:
```yaml
key: ${{ runner.os }}-build-${{ hashFiles('package-lock.json') }}
```

As @takaokouji observed, this means that if a commit or PR doesn't
change `package-lock.json`, the cache key will not change. Two unrelated
builds, possibly with very different content in `src/` or elsewhere,
could share the same build cache. In this case, when the later testing
steps restore the cache, they'll both be testing the same build output.
One of them won't be testing what you expect!

Luckily, the deploy steps also used the same cache keys, so they also
didn't deploy what you expect. I say "luckily" because the alternative
is to release something that didn't run any tests.

All the caching and retrieval steps also took a lot of time, enabled
only a tiny amount of extra parallelism (in the deploy steps), and added
a lot of complexity to the workflow. Removing all of that means a
faster, easier-to-understand workflow with no sneaky gremlins making us
test or deploy the wrong thing.
2024-08-26 14:09:34 -07:00
MiroslavDionisiev
105425909c Revert "ci: reduce package size"
This reverts commit 4cc9f9a2c7.
2024-08-01 11:04:59 +03:00
MiroslavDionisiev
2db6705769 chore: update versions of scratch packages and set-node github action 2024-07-29 17:52:45 +03:00
Christopher Willis-Ford
4cc9f9a2c7 ci: reduce package size 2024-04-11 17:49:18 -07:00
Christopher Willis-Ford
61d154a981 ci: don't hide lint results 2024-03-11 07:04:53 -07:00
Christopher Willis-Ford
c13dbc1b72 ci: use preinstalled Chrome/ium + driver 2024-02-16 17:29:39 -08:00
Christopher Willis-Ford
9dd81cb394 fix(deps): don't use NPM chromedriver package 2024-02-16 17:29:39 -08:00
renovate[bot]
00841ccd6b
chore(deps): pin dependencies 2024-02-16 02:36:18 +00:00
Christopher Willis-Ford
7d38482872 ci: fix deploy 2024-01-09 11:07:09 -08:00
Ron de las Alas
b3ba6b7dee ci: two small changes 2023-11-15 13:41:40 -05:00
Ron de las Alas
72516562be ci: conditionally run deploy jobs 2023-11-14 14:54:04 -05:00
Ron de las Alas
6b5c015c04 ci: add translation job 2023-11-14 13:25:37 -05:00
Ron de las Alas
c9830328bd ci: add main workflow
- add setup
- cache dependencies and dependency outputs
- add build job
- add unit test job
- add integration test job
- add npm deploy
- add gh pages deploy
2023-11-13 18:13:49 -05:00
Maxim Schram
4ca0990634 chore: gha boiler plate. nvmrc file 2023-11-02 09:35:01 -04:00
chrisgarrity
6410108da7
Update contributor guidelines 2020-06-08 14:53:53 -04:00
Ray Schamp
0d40180ee6
Capitalize and reduce number of items
Thanks @niccokunzmann!
2018-06-19 09:15:47 -04:00
Nicco Kunzmann
1692d1438b
Close issues automatically
Problem: Some issues are kept open after the pull request is merged
Solution: Add a "resolves" to the issue template so they are closed by default.
https://help.github.com/articles/closing-issues-using-keywords/
2018-06-16 08:43:19 +02:00
BryceLTaylor
3fdbfa85e2 Add instructions to PR template browser coverage section 2018-05-09 15:59:48 -04:00
Bryce Taylor
e58bf9f674
Update PULL_REQUEST_TEMPLATE.md 2018-05-01 14:24:29 -04:00
Andrew Sliwinski
55dcffbde2 Fix links in contribution guidelines 2017-01-17 17:16:58 -05:00
Andrew Sliwinski
c1ad836596 Improve contribution guidelines and issue/pr templates 2017-01-17 17:13:21 -05:00